wash/mango
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

sandbox: vm: fix bad array index in replenish_free_page_list

Browse Source
This commit is contained in:
max 🍓
2023-02-02 16:47:32 +00:00
parent 49e23849a5
commit ab46b7cd13
1 changed files with 3 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
sandbox/vm/zone.c
View File

@@ -164,27 +164,16 @@ static int replenish_free_page_list(vm_zone_t *z, vm_page_order_t order)
take a page, split it in half, and add the sub-pages take a page, split it in half, and add the sub-pages
to the next order's free list. */ to the next order's free list. */
for (vm_page_order_t i = first_order_with_free; i > order; i--) { for (vm_page_order_t i = first_order_with_free; i > order; i--) {
queue_entry_t *pg_entry = queue_pop_front(&z->z_free_pages[order]); queue_entry_t *pg_entry = queue_pop_front(&z->z_free_pages[i]);
vm_page_t *pg = QUEUE_CONTAINER(vm_page_t, p_free_list, pg_entry); vm_page_t *pg = QUEUE_CONTAINER(vm_page_t, p_free_list, pg_entry);
vm_page_t *a, *b; vm_page_t *a, *b;
vm_page_split(pg, &a, &b); vm_page_split(pg, &a, &b);
queue_push_back(&z->z_free_pages[order - 1], &a->p_free_list); queue_push_back(&z->z_free_pages[i - 1], &a->p_free_list);
queue_push_back(&z->z_free_pages[order - 1], &b->p_free_list); queue_push_back(&z->z_free_pages[i - 1], &b->p_free_list);
} }
/* handle the last order separately. if the requested order is 0 (4K)
handling it within the for-loop would cause an underflow */
queue_entry_t *pg_entry = queue_pop_front(&z->z_free_pages[order + 1]);
vm_page_t *pg = QUEUE_CONTAINER(vm_page_t, p_free_list, pg_entry);
vm_page_t *a, *b;
vm_page_split(pg, &a, &b);
queue_push_back(&z->z_free_pages[order - 1], &a->p_free_list);
queue_push_back(&z->z_free_pages[order - 1], &b->p_free_list);
return 0; return 0;
} }