From 929560e0558021b0e56e22110672a0cec67ee007 Mon Sep 17 00:00:00 2001 From: Max Wash Date: Tue, 6 Jun 2023 21:50:02 +0100 Subject: [PATCH] obj: fix kmalloc'd namespace paths not being null-terminated --- obj/namespace.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/obj/namespace.c b/obj/namespace.c index d6df0c2..0514cac 100644 --- a/obj/namespace.c +++ b/obj/namespace.c @@ -114,12 +114,13 @@ kern_status_t object_namespace_get_object(struct object_namespace *ns, const cha } size_t parts = 0; - char *rpath = kmalloc(path_len, 0); + char *rpath = kmalloc(path_len + 1, 0); if (!rpath) { return KERN_NO_MEMORY; } memcpy(rpath, path, path_len); + rpath[path_len] = 0; cleanup_object_path(rpath, path_len, &parts); char *sp; @@ -190,12 +191,13 @@ kern_status_t object_namespace_create_link(struct object_namespace *ns, const ch } size_t parts = 0; - char *rpath = kmalloc(path_len, 0); + char *rpath = kmalloc(path_len + 1, 0); if (!rpath) { return KERN_NO_MEMORY; } memcpy(rpath, linkpath, path_len); + rpath[path_len] = 0; cleanup_object_path(rpath, path_len, &parts); char *p = rpath + strlen(rpath) - 1;